354 fix redos vulnerable regex patterns#398
Open
heathdutton wants to merge 1 commit intoNASA-AMMOS:mainfrom
Open
354 fix redos vulnerable regex patterns#398heathdutton wants to merge 1 commit intoNASA-AMMOS:mainfrom
heathdutton wants to merge 1 commit intoNASA-AMMOS:mainfrom
Conversation
Collaborator
|
@heathdutton , thanks for your interest and contribution. We haven't yet established the process for outside contributions. We'll check with the AMMOS program office and get back to you. Stay tuned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #354
Replaces two regex patterns that were vulnerable to catastrophic backtracking (ReDoS) with equivalent patterns using negated character classes.
BaseMCWSPersistenceProvider.js:.*/(.*?)$replaced with([^/]*)$-- eliminates backtracking on the greedy.*while still capturing the last path segment.Dataset.js:\/.*Dictionary\/?$replaced with\/[^/]*Dictionary\/?$-- constrains the wildcard to a single path segment, which is all it ever needs to match.Both patterns produce identical results for all valid inputs.