Conversation
|
Replaces: #395 |
|
davetsay
left a comment
There was a problem hiding this comment.
This is a good stuff. I wonder, if we are going for initial load time here, I think we can explicitly wait for all datasets to load intially, then start polling afterwards to monitor for changes.
I don't know that we can, wouldn't we need to know how many datasets exist to do this? I think this is a good solution for the "let's be able to select a session as soon as we can" situation. Even if on the off chance a dataset comes in after the 1 second wait time in SessionService, they'd still see that the next time poll runs 15 seconds later in RealtimeSessionIndictator, so I think this is a pretty solid solution. |
…had thrown, using strict equality, some code cleanup and logic fixes to prevent loops


Implements #393
Fixes an issue in getTopicsWithSessions interaction with persistence storage that caused a minimum of 15s delay before realtime sessions were stored.
old behavior: getTopicsWithSessions would check the dataset cache with getDatasets. The problem is that this is a race condition with MIO loads, as when it runs there are almost never any datasets loaded yet.
new behavior: