Fix net::ERR_INSUFFICIENT_RESOURCES errors on HTTP2 introduced in 5.4.1#415
Open
jvigliotta wants to merge 1 commit intomainfrom
Open
Fix net::ERR_INSUFFICIENT_RESOURCES errors on HTTP2 introduced in 5.4.1#415jvigliotta wants to merge 1 commit intomainfrom
net::ERR_INSUFFICIENT_RESOURCES errors on HTTP2 introduced in 5.4.1#415jvigliotta wants to merge 1 commit intomainfrom
Conversation
davetsay
approved these changes
Apr 17, 2026
| @@ -59,15 +59,25 @@ export default class BaseMCWSPersistenceProvider { | |||
| * @returns {Promise.<NamespaceDefinition[]>} persistenceNamespaces | |||
| */ | |||
| async getPersistenceNamespaces() { | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| async getPersistenceNamespaces() { | |
| async getPersistenceNamespaces() { | |
| if (!this.persistenceNamespaces) { | |
| this.persistenceNamespaces = (async () => { | |
| const rootNamespaces = await this.getRootNamespaces(); | |
| const allContainedNamespaces = await this.getAllContainedNamespaces(rootNamespaces); | |
| const persistenceNamespaces = [...rootNamespaces, ...allContainedNamespaces]; | |
| return persistenceNamespaces; | |
| })(); | |
| } | |
| return this.persistenceNamespaces; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses: #373
Main fix here is the removal of
keapalive = truefor fetch options. This was introduced to increase load times and testing seemed to indicate it did, though now it's believed that was a false positive. This flag will crush Open MCT using the MCWS Adapter plugin on large quantities of requests. The fix is to remove. We'll do testing to ensure load times aren't affected. Additional fixes for race conditions introduced in trying to fix the underlying issue are included as well as they are good changes.