Skip to content

Fix net::ERR_INSUFFICIENT_RESOURCES errors on HTTP2 introduced in 5.4.1#415

Open
jvigliotta wants to merge 1 commit intomainfrom
openmct-mcws-373
Open

Fix net::ERR_INSUFFICIENT_RESOURCES errors on HTTP2 introduced in 5.4.1#415
jvigliotta wants to merge 1 commit intomainfrom
openmct-mcws-373

Conversation

@jvigliotta
Copy link
Copy Markdown
Collaborator

@jvigliotta jvigliotta commented Apr 14, 2026

addresses: #373

Main fix here is the removal of keapalive = true for fetch options. This was introduced to increase load times and testing seemed to indicate it did, though now it's believed that was a false positive. This flag will crush Open MCT using the MCWS Adapter plugin on large quantities of requests. The fix is to remove. We'll do testing to ensure load times aren't affected. Additional fixes for race conditions introduced in trying to fix the underlying issue are included as well as they are good changes.

@jvigliotta jvigliotta requested a review from davetsay April 14, 2026 20:19
@@ -59,15 +59,25 @@ export default class BaseMCWSPersistenceProvider {
* @returns {Promise.<NamespaceDefinition[]>} persistenceNamespaces
*/
async getPersistenceNamespaces() {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async getPersistenceNamespaces() {
async getPersistenceNamespaces() {
if (!this.persistenceNamespaces) {
this.persistenceNamespaces = (async () => {
const rootNamespaces = await this.getRootNamespaces();
const allContainedNamespaces = await this.getAllContainedNamespaces(rootNamespaces);
const persistenceNamespaces = [...rootNamespaces, ...allContainedNamespaces];
return persistenceNamespaces;
})();
}
return this.persistenceNamespaces;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants