Ensure blank sequence opened on new page shows correct right side tabs#1924
Merged
Conversation
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
requested review from
dandelany
and removed request for
joswig and
mattdailis
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
approved these changes
Apr 30, 2026
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
👍 looks good, tested locally
dandelany
force-pushed
the
fix/default-sequence-file-tab-fix
branch
from
d5ced45 to
09978e2
Compare
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
requested changes
Apr 30, 2026
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
Deferring this for now since it's stuck on an e2e test failure and not an obvious fix. Something is causing the "Cancel discards user metadata changes" test to fail - I fixed one issue but now it's complaining about a button not being clickable and I can't figure out why without a deep dive... @AaronPlave can you take a look tomorrow?
AaronPlave
force-pushed
the
fix/default-sequence-file-tab-fix
branch
from
e7d5dd6 to
34f95b8
Compare
Contributor
Author
|
@dandelany tests passing |
dandelany
reviewed
May 8, 2026
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
force-pushed
the
fix/default-sequence-file-tab-fix
branch
from
2d0cec5 to
fa83629
Compare
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
force-pushed
the
fix/default-sequence-file-tab-fix
branch
from
fa83629 to
381b365
Compare
dandelany
approved these changes
May 26, 2026
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
Issues resolved, re-tested locally and all looks good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the selected command and command dictionary right side tabs were not being shown after workspace page load with no file in the url (blank sequence)