fix(docker): install libXpm and generate GUI command wrappers for xvd - #16
Merged
Conversation
The opensource base image shipped the VICAR GUI binaries (xvd, xvd_blink, xvd_save_script) under gui/lib but never put them on PATH and was missing libXpm.so.4, so xvd failed with a shared-library error and was not discovered by vicar-native-toolkit. - Add libXpm to the X11 runtime lib install list (fixes libXpm.so.4 not found) - Add a GUI wrapper-generation block that creates /usr/local/bin wrappers for executables under gui/lib/$ARCH_DIR (xvd and friends), matching the existing p2/tae/mars wrapper pattern xvd now works on both the opensource image and the M20 adaptation (which is FROM the opensource base).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opensource base image shipped the VICAR GUI binaries (xvd, xvd_blink, xvd_save_script) under gui/lib but never put them on PATH and was missing libXpm.so.4, so xvd failed with a shared-library error and was not discovered by vicar-native-toolkit.
xvd now works on both the opensource image and the M20 adaptation (which is FROM the opensource base).