Conversation
Add open-source VICAR build with pre-built binaries
Fix github actions test
Debug tests
…bproject - Move Dockerfile, vicario script, and .dockerignore to terrain-intelligence-generator/ - Rename image from vicar-native-toolkit to terrain-intelligence-generator - Update GitHub Actions workflow and paths - Update docker-compose.yml image reference
…elligence-generator
…nerator Extract terrain intelligence generator
Try to handle vicar exit codes
Update documentation for the image renaming
…e quality - Add Java vicario JAR (17MB FAT JAR with dependencies) - Create wrapper script for automatic rescaling (oform=byte rescale=true) - Add VICARIO.md documentation for building/obtaining JAR - Add .dockerignore to optimize build context - Fixes black image issue by properly rescaling 16-bit VICAR to 8-bit output The Java implementation provides correct dynamic range handling that was missing in the Python version, resulting in visible images instead of black.
…e quality - Add Java vicario JAR (17MB FAT JAR with dependencies) - Create wrapper script for automatic rescaling (oform=byte rescale=true) - Add VICARIO.md documentation for building/obtaining JAR - Add .dockerignore to optimize build context - Fixes black image issue by properly rescaling 16-bit VICAR to 8-bit output The Java implementation provides correct dynamic range handling that was missing in the Python version, resulting in visible images instead of black.
Previous whitelist approach was blocking the JAR file. Now only excludes logs and temporary files.
Previous whitelist approach was blocking the JAR file. Now only excludes logs and temporary files.
- Resolved conflicts in .gitignore, Dockerfile, demo scripts - Kept open-source approach (ours) for VICARIO.md and vicario.md - Removed VISOR data from Docker image (saves 3GB) - Image size reduced from 8.5GB to 5.5GB - All demos tested and working with new image
- Add DEMO.md with step-by-step mesh generation walkthrough - Move 5 documentation files to docs/ directory - CONFIGURATION.md - MOUNTING-DATA.md - OPENSOURCE-BUILD.md - QUICKREF.md - VICAR_NATIVE_TOOLKIT_WALKTHROUGH.md - Update all documentation references in README files - Keep README.md and DEMO.md in toolkit root for visibility
- Combined both Quick Start approaches (Option A: Pre-computed XYZ, Option B: Full Stereo) - Preserved detailed marsmesh output file descriptions (OBJ, MTL, IV, LBL) - Kept comprehensive workspace file listing with all intermediate files - Added Workflow 1 (Quick Test) before Full Pipeline workflow - Updated documentation links to use docs/ folder structure
…header files from vicar and externals.
- Remove docs/superpowers/ from git (kept on filesystem) - Add docs/superpowers/ to .gitignore - Design documents moved to private workspace
- Change build context from ./terrain-intelligence-generator to ./terrain-intelligence-generator/docker - Allows Dockerfile COPY command to access vicario.jar in same directory - Fixes build failures in GitHub Actions due to missing vicario.jar
Adding java vicario in anticipation of public release.
… VISOR data test - Remove $LD_LIBRARY_PATH self-reference in Dockerfile (line 99) Variable doesn't exist yet, causing undefined variable warning - Update Test 11 to verify VISOR data is NOT bundled (correct behavior) VISOR calibration and sample data should be mounted at runtime - Update workflow documentation to reflect external mount design
Fix/GitHub actions visor test
The Python-based vicario script and Pillow dependency are no longer needed since vicario was replaced with a Java implementation (vicario.jar). This fixes the CI failure on Test 12 which expected 'import PIL' to succeed. - Remove terrain-intelligence-generator/scripts/vicario (Python script) - Remove python39 and python39-pip from Dockerfile - Remove Python/Pillow CI test, renumber remaining tests (14 total) - Update release notes to reflect Java vicario
Fix/remove python vicario
VICAR commands return non-zero exit codes on success (e.g. gen returns 1). The docker exec test was checking exit codes directly, causing false failures. Now runs commands with || true and verifies success by checking output files instead.
Fix/ci docker exec exit codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.