Fix release build: upgrade maven-compiler-plugin and consolidate Java compiler release target

[jordanpadams]

🗒️ Summary

Fixes a release build failure caused by maven-compiler-plugin:3.8.1 not supporting Java release target 21. The service module overrode maven.compiler.release to 21, but the old plugin version predates Java 21 support, producing: Fatal error compiling: error: release version 21 not supported.

Changes:

• Upgrade maven-compiler-plugin from 3.8.1 → 3.13.0 in root pom.xml (adds Java 21 support)
• Remove maven.compiler.release=21 override from service/pom.xml — no Java 21 language features are in use; service runs on JVM 21 at runtime via BP_JVM_VERSION
• Remove redundant maven.compiler.release=17 from model/pom.xml — already the root default
• Remove unused maven-compiler-plugin.version property from lexer/pom.xml

All submodules now inherit maven.compiler.release=17 from the root pom as a single source of truth.

🤖 AI Assistance Disclosure

• No AI assistance used
• AI used for light assistance (e.g., suggestions, refactoring, documentation help, minor edits)
• AI used for moderate content generation (AI generated some code or logic, but the developer authored or heavily revised the majority)
• AI generated substantial portions of this code

Estimated % of code influenced by AI: 75%

⚙️ Test Data and/or Report

Build configuration fix only — no application logic changed. Validation is that the stable release build which previously failed with release version 21 not supported should now succeed.

Note: Integration tests are failing, but not sure there is much we can do about that right now with the repos a bit out of sync with backwards-incompatible changes

♻️ Related Issues

N/A — fixing stable release pipeline regression.

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Documentation and PR Content

• Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.
• Issue Traceability: The PR is linked to a valid GitHub Issue
• PR Title: The PR title is "user-friendly" clearly identifying what is being fixed or the new feature being added, that if you saw it in the Release Notes for a tool, you would be able to get the gist of what was done.

Security & Quality

• SonarCloud: Confirmed no new High or Critical security findings.
• Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
• Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

• Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
• Coverage: Automated tests cover new logic and edge cases.
• Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Maintenance

• Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud