Fixes a regression in the AWS intialization script for Dev and Test venue#553
Open
tloubrieu-jpl wants to merge 6 commits into
Open
Fixes a regression in the AWS intialization script for Dev and Test venue#553tloubrieu-jpl wants to merge 6 commits into
tloubrieu-jpl wants to merge 6 commits into
Conversation
added 4 commits
July 21, 2026 11:44
…idated in dev, without terragrunt
…idated in dev, without terragrunt
…egistry into isolate_opensearch_tf
added 2 commits
July 24, 2026 06:42
nutjob4life
reviewed
Jul 24, 2026
| if not (tf_dir / "main.tf").exists(): | ||
| print(f"Error: Terraform directory not found or missing main.tf: {tf_dir}") | ||
| if not (tf_dir / marker).exists(): | ||
| print(f"Error: Terraform directory not found or missing {marker}: {tf_dir}") |
Member
There was a problem hiding this comment.
In general diagnostic messages should go to the standard error:
print(
f"Error: Terraform directory not found or missing {marker}: {tf_dir}",
file=sys.stderr
)
nutjob4life
approved these changes
Jul 24, 2026
nutjob4life
left a comment
Member
There was a problem hiding this comment.
Code delta: ✓
One concern: not using sys.stderr
Is it minor? ✓
Approval: ✅
Caveat: review based on visual inspection only; trust accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
The option --terrgrunt was not supported anymore.
🤖 AI Assistance Disclosure
Estimated % of code influenced by AI: _100 %
⚙️ Test Data and/or Report
Tested the full deployment with integration test in the dev venue.
♻️ Related Issues
Necessary for the deployment in test #542
🤓 Reviewer Checklist
Reviewers: Please verify the following before approving this pull request.
Documentation and PR Content
Security & Quality
Testing & Validation
Maintenance