Skip to content

Fixes a regression in the AWS intialization script for Dev and Test venue#553

Open
tloubrieu-jpl wants to merge 6 commits into
developfrom
init_aws_fix
Open

Fixes a regression in the AWS intialization script for Dev and Test venue#553
tloubrieu-jpl wants to merge 6 commits into
developfrom
init_aws_fix

Conversation

@tloubrieu-jpl

Copy link
Copy Markdown
Member

🗒️ Summary

The option --terrgrunt was not supported anymore.

🤖 AI Assistance Disclosure

  • No AI assistance used
  • AI used for light assistance (e.g., suggestions, refactoring, documentation help, minor edits)
  • AI used for moderate content generation (AI generated some code or logic, but the developer authored or heavily revised the majority)
  • AI generated substantial portions of this code

Estimated % of code influenced by AI: _100 %

⚙️ Test Data and/or Report

Tested the full deployment with integration test in the dev venue.

♻️ Related Issues

Necessary for the deployment in test #542

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Documentation and PR Content

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.
  • Issue Traceability: The PR is linked to a valid GitHub Issue
  • PR Title: The PR title is "user-friendly" clearly identifying what is being fixed or the new feature being added, that if you saw it in the Release Notes for a tool, you would be able to get the gist of what was done.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Maintenance

  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

@tloubrieu-jpl
tloubrieu-jpl requested a review from a team as a code owner July 24, 2026 13:36
@tloubrieu-jpl
tloubrieu-jpl changed the base branch from develop to main July 24, 2026 13:38
@tloubrieu-jpl
tloubrieu-jpl changed the base branch from main to develop July 24, 2026 13:38
if not (tf_dir / "main.tf").exists():
print(f"Error: Terraform directory not found or missing main.tf: {tf_dir}")
if not (tf_dir / marker).exists():
print(f"Error: Terraform directory not found or missing {marker}: {tf_dir}")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general diagnostic messages should go to the standard error:

print(
    f"Error: Terraform directory not found or missing {marker}: {tf_dir}",
    file=sys.stderr
)

@nutjob4life nutjob4life left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code delta: ✓
One concern: not using sys.stderr
Is it minor? ✓
Approval: ✅
Caveat: review based on visual inspection only; trust accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants