Refactor code organization after adding Aerosols and Emissions#293
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
+ Coverage 87.57% 87.68% +0.10%
==========================================
Files 41 45 +4
Lines 2479 2484 +5
==========================================
+ Hits 2171 2178 +7
+ Misses 308 306 -2
🚀 New features to boost your workflow:
|
Contributor
|
@boulderdaze I have no problem with the name change since it is purely internal to MC and invisible to MUSICA. |
smeechncar
approved these changes
Jul 8, 2026
K20shores
approved these changes
Jul 8, 2026
K20shores
left a comment
Collaborator
There was a problem hiding this comment.
This makes my soul feel good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Printfunction in the public header used exclusively by google test totest/utils. This avoids including<ostream>and gtest helpers in non-test builds, where they are never used.Versionstruct out ofmechanism. Thepush macro/pop macroglibc workaround is noisy.mechansim.hppnow containsmechanismstruct only , and no platform specific workarounds.boltzmann->BOLTZMANN)emissions_parser.hpp, which bundlesCheckEmissionsSchemaandParseEmissionsSectioninto seperateschema.hppandparser.hppfiles.ParseEmissionsSectiontoParseEmissionsfor consistency. (@smeechncar, let me know what you think about the renaming.)ParseEmissionsSection()intoBuild()so species, phases, reactions, aerosol, and emissions are all assembled in one place.ValidateEmissionsModel.Arrheniuskeys remains at the top level because it is used by both the reactions and aerosols.GetReactionComponentName->GetComponentNamebecause it's also used to extract species names and phase-species names, not just reaction reactants/productssNote: This PR is large, but it contains no actual code changes unless explicitly noted in the comments. The changes are limited to code reorganization, file relocations, and renaming.