Skip to content

Adds solvent floor and min halflife field for aerosol processes#296

Merged
boulderdaze merged 3 commits into
mainfrom
need-solvent-floor-min-halflife
Jul 14, 2026
Merged

Adds solvent floor and min halflife field for aerosol processes#296
boulderdaze merged 3 commits into
mainfrom
need-solvent-floor-min-halflife

Conversation

@boulderdaze

@boulderdaze boulderdaze commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Adds solvent floor and min halflife field for aerosol processes to support MUSICA tutorial.
No tests were added because we aren't sure if this should be part of the user configuration yet.
Issue to track this has been created:

@boulderdaze boulderdaze self-assigned this Jul 10, 2026
@boulderdaze boulderdaze added this to the Cloud Chemistry milestone Jul 10, 2026
@codecov-commenter

codecov-commenter commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.03%. Comparing base (7bf5f06) to head (0c52fc7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files          44       44           
  Lines        2474     2474           
=======================================
  Hits         2178     2178           
  Misses        296      296           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@boulderdaze boulderdaze marked this pull request as ready for review July 13, 2026 16:40
@boulderdaze boulderdaze marked this pull request as draft July 13, 2026 16:40
@boulderdaze boulderdaze marked this pull request as ready for review July 13, 2026 23:10
@boulderdaze boulderdaze requested a review from K20shores July 13, 2026 23:11

@K20shores K20shores left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather do this properly, adding tests, documentation, examples, since there are relatively few of these. If we find out we don't want to support them, we can always revert this PR

@boulderdaze boulderdaze merged commit 3d13e2d into main Jul 14, 2026
26 of 28 checks passed
@boulderdaze boulderdaze deleted the need-solvent-floor-min-halflife branch July 14, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants