Skip to content

Rename Arrhenius reference temperature to Equilibrium#299

Open
boulderdaze wants to merge 3 commits into
mainfrom
incorporate-feedback
Open

Rename Arrhenius reference temperature to Equilibrium#299
boulderdaze wants to merge 3 commits into
mainfrom
incorporate-feedback

Conversation

@boulderdaze

Copy link
Copy Markdown
Contributor

This PR:

  • Renames Arrhenius reference temperature to Equilibrium to address the feedback from Matt
  • Adds Henry's Law constant equation in the comment in configuration requested by Mary

@boulderdaze boulderdaze self-assigned this Jul 15, 2026
@boulderdaze boulderdaze marked this pull request as ready for review July 15, 2026 20:21
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.03%. Comparing base (3d13e2d) to head (4f745da).

Files with missing lines Patch % Lines
src/v1/aerosol/parsers.cpp 83.33% 1 Missing ⚠️
src/v1/aerosol/schema.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files          44       44           
  Lines        2474     2474           
=======================================
  Hits         2178     2178           
  Misses        296      296           
Files with missing lines Coverage Δ
src/v1/aerosol/parsers.cpp 85.00% <83.33%> (ø)
src/v1/aerosol/schema.cpp 78.23% <80.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@boulderdaze boulderdaze requested a review from K20shores July 15, 2026 20:27
},
"equilibrium constant": {
"type": "ARRHENIUS_REFERENCE_TEMPERATURE", "A": 1725.0, "C [K]": 0.0, "T0 [K]": 298.15
"type": "EQUILIBRIUM", "A": 1725.0, "C [K]": 0.0, "T0 [K]": 298.15

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there docs for this in mechanism configuration? If so we should update them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants