Conversation
Notification sounds (e.g. Telegram message received/sent) are typically under 1 second but trigger a full pause of music on other tabs. This adds an "Ignore short media" option with two detection strategies: - Per-media duration check: ContentScript sends element.duration with play messages, background ignores media where duration is finite and < 10s. - Debounce for otherTabs (no content script): delays the pause action by 5 seconds when a tab becomes audible; if it stops being audible before the timer fires, the event is discarded. https://claude.ai/code/session_01HP27yofm1EcQQRuVQRSk41
3 seconds more precisely targets notification/UI sounds (0.3-1.5s) without accidentally ignoring short voice messages or video clips. https://claude.ai/code/session_01HP27yofm1EcQQRuVQRSk41
Telegram (and similar sites) don't load audio metadata until after the play event, so duration is NaN when onPlay fires. Defer the play message until durationchange fires (with a 500ms timeout fallback for streams where durationchange never fires). This ensures short notification sounds are correctly identified even when metadata loads late. https://claude.ai/code/session_01HP27yofm1EcQQRuVQRSk41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#65