Skip to content

spec updates, updates to carry locaiton thru to end and addition of p…#1317

Open
burlingamet wants to merge 4 commits into
masterfrom
swc.dev
Open

spec updates, updates to carry locaiton thru to end and addition of p…#1317
burlingamet wants to merge 4 commits into
masterfrom
swc.dev

Conversation

@burlingamet

Copy link
Copy Markdown
Contributor

…osition loader.

Copilot AI review requested due to automatic review settings July 8, 2026 18:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the concH2oSoilSalinity Pachyderm pipeline wiring to preserve/carry location metadata through intermediate repos and introduces a new position_history_loader pipeline whose outputs are crossed into publication packaging so downstream publication steps can discover CFGLOCs and include position history artifacts.

Changes:

  • Carry location directories forward by adding DirSubCopy=location and explicitly joining */location/** paths in the relevant filter-joiner configs.
  • Add a new concH2oSoilSalinity_position_history_loader pipeline and insert it into the pipeline list.
  • Update pub_format_and_package to cross in the new position-history repo and adjust image/resources; increase resources for the publish egress step.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pipe/concH2oSoilSalinity/pipe_list_concH2oSoilSalinity.txt Adds the new position-history loader pipeline to the execution list.
pipe/concH2oSoilSalinity/concH2oSoilSalinity_stats_group_and_compute.yaml Copies location through stats outputs and joins location JSON paths into the filter-joiner staging.
pipe/concH2oSoilSalinity/concH2oSoilSalinity_qm_join_stats.yaml Copies location through QM outputs and joins location JSON paths into the filter-joiner staging.
pipe/concH2oSoilSalinity/concH2oSoilSalinity_group_split.yaml Ensures location is preserved when splitting/grouping outputs.
pipe/concH2oSoilSalinity/concH2oSoilSalinity_level1_group_consolidate_srf.yaml Ensures location is preserved through Level 1 consolidate by including it in DirSubCopy and DATA_TYPE_NAMES.
pipe/concH2oSoilSalinity/concH2oSoilSalinity_position_history_loader.yaml Introduces a new loader pipeline that generates CFGLOC position-history JSONs from PDR.
pipe/concH2oSoilSalinity/concH2oSoilSalinity_pub_format_and_package.yaml Switches to a cross input including position-history data, updates the image tag, and increases memory limits.
pipe/concH2oSoilSalinity/concH2oSoilSalinity_pub_egress_and_publish.yaml Increases resource requests/limits for the publish/egress stage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pipe/concH2oSoilSalinity/concH2oSoilSalinity_pub_format_and_package.yaml Outdated
burlingamet and others added 3 commits July 8, 2026 11:28
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants