spec updates, updates to carry locaiton thru to end and addition of p…#1317
Open
burlingamet wants to merge 4 commits into
Open
spec updates, updates to carry locaiton thru to end and addition of p…#1317burlingamet wants to merge 4 commits into
burlingamet wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the concH2oSoilSalinity Pachyderm pipeline wiring to preserve/carry location metadata through intermediate repos and introduces a new position_history_loader pipeline whose outputs are crossed into publication packaging so downstream publication steps can discover CFGLOCs and include position history artifacts.
Changes:
- Carry
locationdirectories forward by addingDirSubCopy=locationand explicitly joining*/location/**paths in the relevant filter-joiner configs. - Add a new
concH2oSoilSalinity_position_history_loaderpipeline and insert it into the pipeline list. - Update
pub_format_and_packagetocrossin the new position-history repo and adjust image/resources; increase resources for the publish egress step.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pipe/concH2oSoilSalinity/pipe_list_concH2oSoilSalinity.txt | Adds the new position-history loader pipeline to the execution list. |
| pipe/concH2oSoilSalinity/concH2oSoilSalinity_stats_group_and_compute.yaml | Copies location through stats outputs and joins location JSON paths into the filter-joiner staging. |
| pipe/concH2oSoilSalinity/concH2oSoilSalinity_qm_join_stats.yaml | Copies location through QM outputs and joins location JSON paths into the filter-joiner staging. |
| pipe/concH2oSoilSalinity/concH2oSoilSalinity_group_split.yaml | Ensures location is preserved when splitting/grouping outputs. |
| pipe/concH2oSoilSalinity/concH2oSoilSalinity_level1_group_consolidate_srf.yaml | Ensures location is preserved through Level 1 consolidate by including it in DirSubCopy and DATA_TYPE_NAMES. |
| pipe/concH2oSoilSalinity/concH2oSoilSalinity_position_history_loader.yaml | Introduces a new loader pipeline that generates CFGLOC position-history JSONs from PDR. |
| pipe/concH2oSoilSalinity/concH2oSoilSalinity_pub_format_and_package.yaml | Switches to a cross input including position-history data, updates the image tag, and increases memory limits. |
| pipe/concH2oSoilSalinity/concH2oSoilSalinity_pub_egress_and_publish.yaml | Increases resource requests/limits for the publish/egress stage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…osition loader.