[E] Depositing Improvements, Phase 3#206
Merged
Merged
Conversation
358c127 to
47dd42c
Compare
* Add a new section to `GlobalConfiguration` for `contributors` with
two new boolean properties (both default to `true` for MVP):
* `claimable`: Contributor claiming is enabled. Details below.
* `ownerUpdatable`: Controls whether a contributor that is linked to
a user can be updated by that user.
* Greatly improve the handling of updating contributors and linking
them with user records:
* Add a new mutation, `contributorClaim` that can be used on any
contributor that does not have an attached user record. It
requires claiming to enabled (currently true by default) and
for the user to have a role that grants contributors.claim.
This will be true for depositors, reviewers, and any higher-tier
roles.
* Depositors will now auto-create a contributor if they don't have
a primary contributor assigned to them yet, whether through
claiming or an admin assigning beforehand.
* A submission's user's primary contributor will be assigned as the
author on the generated entity at creation time. It can be edited
afterwards if need be.
* The aforementioned user will also be granted a new system role,
Author, that ensures that they have update access to the entity.
This facilitates being able to specify `access: UPDATE` on
the `items` resolver in order to see which record(s) a depositor
can access. When the submission is published, this role will be
removed (for now). This prevents authors from being able to make
post-publication changes outside of the submission workflow. We
can surface an option to allow this in the future.
* Users who are attached to a contributor can manage that
contributor record themselves. As with claiming, this is also
controlled by the new setting: `contributors.ownerUpdatable`.
* Add the ability to merge contributors. Merging happens in the BG,
but can be kicked off by the `contributorMerge` mutation.
* Port over a number of VOG improvements to be able to test filters
as well as make further improvements to extract framework code out
of app and into `lib/support`.
47dd42c to
68e0eab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GlobalConfigurationforcontributorswith two new boolean properties (both default totruefor MVP):claimable: Contributor claiming is enabled. Details below.ownerUpdatable: Controls whether a contributor that is linked to a user can be updated by that user.contributorClaimthat can be used on any contributor that does not have an attached user record. It requires claiming to enabled (currently true by default) and for the user to have a role that grants contributors.claim. This will be true for depositors, reviewers, and any higher-tier roles.access: UPDATEon theitemsresolver in order to see which record(s) a depositor can access. When the submission is published, this role will be removed (for now). This prevents authors from being able to make post-publication changes outside of the submission workflow. We can surface an option to allow this in the future.contributors.ownerUpdatable.contributorMergemutation.lib/support.