Skip to content

Fix invalid string access in BoundaryLayerTool #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StefanBruens wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix invalid string access in BoundaryLayerTool #204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cb4518
Fix invalid string access in BoundaryLayerTool
StefanBruens Dec 20, 2024
a996c15
Merge branch 'master' into fix_boundarylayer_dangling_reference
StefanBruens Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 33 additions & 10 deletions libsrc/meshing/boundarylayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,8 @@ void BoundaryLayerTool ::CreateFaceDescriptorsSides ()
new_fd.SetBCProperty(new_si);
mesh.AddFaceDescriptor(new_fd);
si_map[facei] = new_si;
mesh.SetBCName(new_si - 1, fd.GetBCName());
// AddFaceDescriptor may reallocate, fd is invalidated
mesh.SetBCName(new_si - 1, mesh.GetFaceDescriptor(facei).GetBCName());
face_done.SetBit(facei);
}
}
Expand Down Expand Up @@ -620,15 +621,37 @@ void BoundaryLayerTool ::InsertNewElements (
double height = 0.0;
for (auto i : Range(par_heights))
{
height += par_heights[i];
auto pi_new = mesh.AddPoint(p);
// mesh.AddLockedPoint(pi_new);
mapfrom.Append(pi);
new_points.Append(pi_new);
growth_vector_map[pi_new] = {&growth_vector, height};
// if (special_boundary_points.count(pi) > 0)
// mesh.AddLockedPoint(pi_new);
pi_last = pi_new;
auto facei = sel.GetIndex();
if(face_done.Test(facei))
continue;
bool point_moved = false;
// bool point_fixed = false;
for(auto pi : sel.PNums())
{
if(growthvectors[pi].Length() > 0)
point_moved = true;
/*
else
point_fixed = true;
*/
}
if(point_moved && !moved_surfaces.Test(facei))
{
int new_si = mesh.GetNFD()+1;
const auto& fd = mesh.GetFaceDescriptor(facei);
// auto isIn = domains.Test(fd.DomainIn());
// auto isOut = domains.Test(fd.DomainOut());
int si = params.sides_keep_surfaceindex ? facei : -1;
// domin and domout can only be set later
FaceDescriptor new_fd(si, -1,
-1, si);
new_fd.SetBCProperty(new_si);
mesh.AddFaceDescriptor(new_fd);
si_map[facei] = new_si;
// AddFaceDescriptor may reallocate, fd is invalidated
mesh.SetBCName(new_si-1, mesh.GetFaceDescriptor(facei).GetBCName());
face_done.SetBit(facei);
}
}
};

Expand Down