Skip to content

Fix test suite tmp dir issue#150

Merged
steventux merged 2 commits into
mainfrom
fix-test-suite-tmp-dir-issue
Jun 26, 2026
Merged

Fix test suite tmp dir issue#150
steventux merged 2 commits into
mainfrom
fix-test-suite-tmp-dir-issue

Conversation

@steventux

@steventux steventux commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • TestCreateWorklistItem was generating directories with test.db in them in the project root. self was missing from a fixture.
  • tmp_path was used in places instead of tmp_dir, made this consistent.
  • Readable test names made Neotest stop working, small fix for this.

Jira link

Review notes

Review checklist

  • Check database queries are correctly scoped to current_provider

steventux added 2 commits June 26, 2026 10:47
@steventux
Fix issue where test.db was created in project root
29a8002
@steventux
Make readable test names play nicely with neotest
db8a01a 
Pytest uses :: as a delimiter in tests and apparently the neotest plugin relies on this for _stuff_.
@steventux steventux requested a review from carlosmartinez June 26, 2026 10:08
carlosmartinez
carlosmartinez approved these changes Jun 26, 2026
View reviewed changes

@carlosmartinez carlosmartinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steventux steventux merged commit e123943 into main Jun 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosmartinez carlosmartinez carlosmartinez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@steventux @carlosmartinez