Skip to content

BCSS-23565 - feat(waf): create new WAF module#96

Merged
nhs-oliverslater merged 12 commits into
mainfrom
feature/BCSS-23565-WAF-tf-module
Jun 29, 2026
Merged

BCSS-23565 - feat(waf): create new WAF module#96
nhs-oliverslater merged 12 commits into
mainfrom
feature/BCSS-23565-WAF-tf-module

Conversation

@DeepikaDK001

@DeepikaDK001 DeepikaDK001 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Pira-nhs

Copy link
Copy Markdown
Contributor

Good start on the WAF module. I think we're in good shape to consume this when building the app stack. It does appear to expose a lot of the CloudPosse API but we can trim this down as we build stack

@Pira-nhs

Pira-nhs commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Without trying to be too picky can we make the readme.md in caps "README.MD" just for consistency sake and ensure the readme follows formatting standard headings and sections etc

Comment thread infrastructure/modules/waf/locals.tf Outdated
Comment thread infrastructure/modules/waf/README.md
Comment thread infrastructure/modules/waf/README.md
@nhs-oliverslater nhs-oliverslater changed the title BCSS-23565 create terraform module WAF BCSS-23565 - feat(waf): create new WAF module Jun 27, 2026
@nhs-oliverslater nhs-oliverslater marked this pull request as ready for review June 29, 2026 14:32
@nhs-oliverslater nhs-oliverslater requested review from a team as code owners June 29, 2026 14:32
@nhs-oliverslater nhs-oliverslater enabled auto-merge (squash) June 29, 2026 14:34
@nhs-oliverslater nhs-oliverslater merged commit 62cfca6 into main Jun 29, 2026
34 checks passed
@nhs-oliverslater nhs-oliverslater deleted the feature/BCSS-23565-WAF-tf-module branch June 29, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants