Fix install scripts for PEP668#44
Merged
yacchin1205 merged 3 commits intoNII-cloud-operation:masterfrom May 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes installation issues related to PEP668 by updating Ubuntu support across installation scripts, documentation, and CI workflows.
- Added the installation of python3-tornado in the install script for Ubuntu systems.
- Updated README.md to list Ubuntu 24.04 as supported.
- Enhanced the GitHub Actions workflow to include Ubuntu 24.04 in the test matrix.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| install-host-services.sh | Added apt-get install for python3-tornado and removed redundant pip command. |
| README.md | Updated the supported OS list to include Ubuntu 24.04. |
| .github/workflows/test.yml | Extended the test matrix and dynamically set runs-on based on ubuntu_version. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the installation process for Ubuntu 24.04 by addressing PEP668 issues, updating documentation, and adjusting test configurations.
- install-host-services.sh: Adds python3-tornado installation for Ubuntu and removes a redundant pip3 install command.
- README.md: Updates the list of supported operating systems to include Ubuntu 24.04.
- .github/workflows/test.yml: Introduces an ubuntu_version matrix parameter and refactors job configuration to dynamically adjust runner versions and compose commands.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| install-host-services.sh | Adds python3-tornado installation and removes pip3 install for tornado. |
| README.md | Updates supported OS list to include Ubuntu 24.04. |
| .github/workflows/test.yml | Replaces fixed runner versions with a dynamic ubuntu_version and updates compose commands accordingly. |
shingo78
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the installation process for Ubuntu 24.04 where the Python package fail to install due to PEP 668. This fix makes it possible to use it on Ubuntu 24.04, so I have updated the documentation and the tests.
install-host-services.sh: Addedpython3-tornadoinstallation for Ubuntu systems and removed a redundantpip3 install tornadocommand.README.md: Updated the list of supported operating systems to include Ubuntu 24.04..github/workflows/test.yml: Addedubuntu_versionas a matrix parameter and updated job configurations to include Ubuntu 24.04. Changedruns-onto dynamically use theubuntu_versionfrom the matrix.