docs(ntt): make the constant-time caveat prominent, not buried#53
Merged
Conversation
A reader in r/cryptography asked for this explicitly: the caveat about the Barrett-reduction canonicalization step not being fully constant-time was previously only mentioned mid-page under "What it solves" and in a callout under "Barrett reduction". Moves it to a blockquote warning immediately after the title, before any other content, and adds a matching flag to the README's module table so it's visible without even opening the docs page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct response to feedback on r/cryptography:
docs/algorithms/ntt.mdand README.md now flag the constant-time caveat at the top, not buried mid-page.