Complete multi-platform validation for numx_cholesky_decompose#85
Open
abkhoshk wants to merge 1 commit into
Open
Complete multi-platform validation for numx_cholesky_decompose#85abkhoshk wants to merge 1 commit into
abkhoshk wants to merge 1 commit into
Conversation
Add self-contained ESP32-S3 test for Cholesky decomposition. Update validation results and prompt for multi-platform Cholesky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the multi-platform validation sweep for
numx_cholesky_decompose(originally added in #51), bringing it in line with every other function inlinalg. Previously only one platform had been validated; this PR adds results for Windows x86/x64, Linux x86 (32-bit)/x86-64 (WSL2), Raspberry Pi 4 (armhf), and ESP32-S3.Changes
examples/esp32_cholesky_test/(mirroringexamples/esp32_ntt_test/), since the on-device ESP32 test harness had no Cholesky coverage. It linkssrc/linalg.cdirectly and runs the six existing test cases plus a benchmark loop over UART.validation/prompts/cholesky_rpi_esp32_validation_prompt.md, a self-contained task prompt documenting the workflow used to validate on the Raspberry Pi 4 and ESP32-S3.validation/results/linalg/cholesky_decompose.md: Windows x86 (float32), Windows x64 (float64), Linux x86 WSL2 (float32), Linux x86-64 WSL2 (float64), Raspberry Pi 4 armhf (float32), and ESP32-S3 (float32). Existing sections are left untouched; the old "Remaining validation" note is replaced with a completion summary.Results
All 6 Cholesky test cases and the corresponding validation-runner checks pass on every platform (337/337 Unity tests on the desktop/Pi builds, 23/23 assertions on the ESP32 harness), with zero failures.