Skip to content

Make State load only from scratch and not into existing state#520

Merged
tertsdiepraam merged 1 commit into
mainfrom
state-from-scratch
Apr 7, 2026
Merged

Make State load only from scratch and not into existing state#520
tertsdiepraam merged 1 commit into
mainfrom
state-from-scratch

Conversation

@tertsdiepraam

Copy link
Copy Markdown
Contributor

This allows us to get rid of some tracking of whether policies and zones are added, retained, removed or updated.

@ximon18

ximon18 commented Mar 19, 2026

Copy link
Copy Markdown
Member

What prompted this change? Is this functionality okay to remove? Is the removed behaviour something we never used or needed?

@tertsdiepraam

Copy link
Copy Markdown
Contributor Author

I believe that we will never read state after starting up (maybe until we get to high availability but at that point we probably need to reconsider anyway).

@ximon18
ximon18 requested a review from bal-e March 27, 2026 11:35

@bal-e bal-e left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Simplifying this makes it easier for us to control the zone initialization code (which would be useful for resolving some workarounds in #552, although we'll get to them later).

@tertsdiepraam
tertsdiepraam merged commit c11ab51 into main Apr 7, 2026
9 checks passed
@tertsdiepraam
tertsdiepraam deleted the state-from-scratch branch April 7, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants