IXFR-out system tests.#650
Open
ximon18 wants to merge 54 commits into
Open
Conversation
Will need changing based on PR #589.
Also add a guard and improve the actual logged output.
Primarily to cover the wider than perhaps expected use of the soa() fn.
Currently fails due to an unrelated TSIG bug causing dig to fail.
As step.if doesn't seem to be honoured by nektos/act.
Not via TCP but via single SOA response, per RFC 1995. Also adds a system test using dig.
Incremental signing doesn't change the loaded zone so don't expect a non-empty loaded diff.
(and correctly, as in theory you could, especially with keep serial policy, have requested the right serial number from the loaded review server and have received a signed diff back...!)
This reverts commit 0c692c6.
And log an error.
ximon18
force-pushed
the
ixfr-out-system-tests
branch
from
May 12, 2026 12:00
a4965b1 to
b7ce437
Compare
Not on the review servers.
ximon18
changed the title
ximon18
added a commit
that referenced
this pull request
May 12, 2026
Validated with the ixfr-out system test from PR #650.
ximon18
added
the
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @Philip-NLnetLabs.
Includes system tests that exercise:
IXFR out with and without TSIG to a downstream NSD instance.
Editing a local zone file and instructing Cascade to reload it. The zone and the edits to it are based on the example in section 7 of RFC 1995.
Verifies that if TSIG is configured that TSIG is required.
Verifies that a client using UDP is signalled via the RFC 1995 single SOA response mechanism to retry with TCP.
Verifies IXFR out content against expectations for a client requesting serial 1, 2 and 3.
Verifies that NSD accepts the IXFR transfer and produces the expected resulting final AXFR output.
Querying the review servers. HOWEVER, these tests are not correct as the review server should be queried while the zone is held for review!
If you are changing Rust code or integration tests (
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?NOTE: of the three system tests for
ixfr-outin this PR, theixfr-out-incrementaltest is currently failing. This could be a timing issue, precisely the concern raised about time based tests.Relates to #300.