Refactor signing code out of zone_signer.rs#718
Merged
Conversation
bal-e
force-pushed
the
refactor-key-loading
branch
from
June 8, 2026 11:32
ed5782f to
7ebe8a4
Compare
ximon18
reviewed
Jun 8, 2026
bal-e
force-pushed
the
refactor-key-loading
branch
from
July 3, 2026 15:17
99d5a39 to
5d6c5d8
Compare
1 task
ximon18
approved these changes
Jul 6, 2026
ximon18
left a comment
ximon18
left a comment
Member
There was a problem hiding this comment.
I like this a lot. I just noted a couple of minor things I wanted to raise, see my comments, but they are not blocking.
bal-e
changed the title
signer/keys.rszone_signer.rs
ximon18
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #630 I noticed key loading functionality was distributed throughout
zone_signer.rsand thought it nice to move it to a dedicated file. Along the way, I cleaned up some error messages, and turned some panics into signing failures (related to the client credentials store).This PR also includes #865. Together, they move the vast majority of functionality out of
zone_signer.rs.Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?