Skip to content

Test canonical compare for NSEC in incremental signing.#848

Open
Philip-NLnetLabs wants to merge 2 commits into
mainfrom
test-canonical-cmp-for-nsec
Open

Test canonical compare for NSEC in incremental signing.#848
Philip-NLnetLabs wants to merge 2 commits into
mainfrom
test-canonical-cmp-for-nsec

Conversation

@Philip-NLnetLabs

@Philip-NLnetLabs Philip-NLnetLabs commented Jun 26, 2026

Copy link
Copy Markdown
Member

Provide your description here


  • If you are changing Rust code or integration tests (Cargo.*, crates/, etc/, integration-tests/, src/):
    • Did you run the integration tests with act through the act-wrapper (as described in TESTING.md)?

@ximon18 ximon18 added the testing Automatic verification of Cascade's correctness and reliability. label Jun 26, 2026

@bal-e bal-e left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright -- but it's hard (time-consuming) to figure out exactly what is changing in the zonefiles. I'd love to find a way, in the future, of generating these zonefiles programmatically, so the differences become more clear.

@Philip-NLnetLabs

Philip-NLnetLabs commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

I maintain them using:
$ diff -u zones/incremental-signing-test1-input*

@Philip-NLnetLabs

Copy link
Copy Markdown
Member Author

Would it help if I add the diff command to the top of each zone file?

@bal-e

bal-e commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

I'll use diff and review again.

@bal-e
bal-e self-requested a review July 1, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Automatic verification of Cascade's correctness and reliability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants