Test canonical compare for NSEC in incremental signing.#848
Open
Philip-NLnetLabs wants to merge 2 commits into
Open
Test canonical compare for NSEC in incremental signing.#848Philip-NLnetLabs wants to merge 2 commits into
Philip-NLnetLabs wants to merge 2 commits into
Conversation
bal-e
approved these changes
Jun 29, 2026
bal-e
left a comment
Contributor
There was a problem hiding this comment.
Looks alright -- but it's hard (time-consuming) to figure out exactly what is changing in the zonefiles. I'd love to find a way, in the future, of generating these zonefiles programmatically, so the differences become more clear.
Member
Author
|
I maintain them using: |
Member
Author
|
Would it help if I add the diff command to the top of each zone file? |
Contributor
|
I'll use |
bal-e
self-requested a review
July 1, 2026 11:42
bal-e
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide your description here
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?