Skip to content

Report signing step to zone status#882

Open
tertsdiepraam wants to merge 6 commits into
mainfrom
signing-steps
Open

Report signing step to zone status#882
tertsdiepraam wants to merge 6 commits into
mainfrom
signing-steps

Conversation

@tertsdiepraam

@tertsdiepraam tertsdiepraam commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Does a few things:

  • Report signing steps to the zone status.
  • This required adding a step to the SigningStatus, which kind of overlaps with the current_action but I left that in, because that still shows more granular information that might be helpful for debugging or something.
  • There was some info in the status that was shown as "not yet known" even though it was, because the HTTP server only included the signing report on signing review, which is now fixed.
  • We now also trigger SigningStatus::InProgress in incremental signing, which turned out to not happen yet.
  • We now show the signed serial in the zone status because we now take it from the signing status and not from the signed_review_soa on the storage because the signer knows the serial earlier.
  • We now also show the signing strategy (full or incremental).
  • Finally, some unused metrics were removed. They were also not created for incremental signing, so this is not a very big deal.
zone:   se
policy: default
source: /home/terts/data/zones/se.zone.stripped.txt

review
  loaded: off
  signed: off

last published
  <no versions published yet>

status: signing
  ✔ load (serial: 1776081352)
  ○ review loaded zone (disabled)
  ● sign (serial: 2026071300)
  |   loaded serial: 1776081352
  |   signed serial: 2026071300
  |   strategy: sign the entire zone
  |   step 1/5: collecting records
  |   start time: 2026-07-13T14:18:15 (9s ago)
  |
  ○ review signed zone (disabled)
  ○ publish

  • If you are changing Rust code or integration tests (Cargo.*, crates/, etc/, integration-tests/, src/):
    • Did you run the integration tests with act through the act-wrapper (as described in TESTING.md)?

Base automatically changed from signed-serial-computation to main July 10, 2026 09:39
@tertsdiepraam
tertsdiepraam marked this pull request as ready for review July 13, 2026 12:29
@ximon18

ximon18 commented Jul 13, 2026

Copy link
Copy Markdown
Member

I haven't read the changes yet but I like the CLI output updates shown in the PR description!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants