Notify#7
Merged
Merged
Conversation
12 tasks
tertsdiepraam
marked this pull request as ready for review
October 24, 2024 11:30
mozzieongit
requested changes
Oct 29, 2024
mozzieongit
left a comment
mozzieongit
left a comment
Member
There was a problem hiding this comment.
It looked like you're mostly done, so I checked it out. There's a left-over TODO though.
mozzieongit
reviewed
Oct 30, 2024
Co-authored-by: Jannik <jannik@nlnetlabs.nl>
mozzieongit
reviewed
Oct 30, 2024
mozzieongit
reviewed
Nov 1, 2024
Member
|
FYI: ldns-notify supports |
tertsdiepraam
marked this pull request as draft
November 20, 2024 10:06
tertsdiepraam
marked this pull request as ready for review
November 22, 2024 14:44
Merged
bal-e
reviewed
Nov 26, 2024
bal-e
left a comment
bal-e
left a comment
Contributor
There was a problem hiding this comment.
Really well done, @tertsdiepraam! This is some complex code but I like the way you've managed to get through it!
ximon18
reviewed
Nov 26, 2024
bal-e
approved these changes
Nov 29, 2024
bal-e
left a comment
bal-e
left a comment
Contributor
There was a problem hiding this comment.
Nicely done, @tertsdiepraam!
mozzieongit
requested changes
Dec 2, 2024
mozzieongit
left a comment
mozzieongit
left a comment
Member
There was a problem hiding this comment.
Last complaints, I swear! ... maybe :D
Contributor
Author
|
@mozzieongit do your worst! Give me that great feedback! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
ldns-notifyanddnst notify.