Report zonefile parsing & signing progress to the caller.#448
Closed
ximon18 wants to merge 25 commits into
Closed
Conversation
ximon18
force-pushed
the
report-signing-progress
branch
from
December 5, 2024 11:57
99e0d40 to
2a8816f
Compare
… output format. (#463)
ximon18
changed the base branch from
byo-signing-sorter-impl
to
multiple-key-signing
December 19, 2024 08:25
ximon18
changed the base branch from
multiple-key-signing
to
initial-nsec3-generation
December 19, 2024 08:27
Contributor
|
@ximon18 this has some conflicts. Do we need to keep this around? |
Member
Author
|
This parser is currently used by Cascade so assuming these changes are part of the patches-for-nameshed-prototype branch then they benefit Cascade users. Anyone using this "old" parser benefits from these changes so yes, however, we were planning to switch to the new-xxx parser which would replace this parser. |
Member
|
@ximon18, would you then mind fixing the conflicts and, if you feel the PR is ready for review, remove the draft status? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows callers to report progress, which is especially useful on very large zone files.
For example usage see NLnetLabs/dnst#35.
I'm not very happy with the
inplace::Zonefileprogress support, but due to the replacement of self via the Bytessplit()operation, reset of thestartvariable and the iterator being mutably consumed by the caller, using a new position tracking variable and returning it viaEntryseemed like one easy way of getting the progress information out to the iterating caller code.Perhaps something like
Iterator::enumerate()could be used instead to return the progress offset to the iteration loop?If we keep the extra var returned with
Entryit should probably be made into named struct fields instead of anonymous tuple fields, to be more self-evident what theusizevalue is. Also, the extra tuple field infects all call sites which is annoying as most don't care about it.Note: This PR lacks progress notification for NSEC hashing, that should also be added.
Thoughts:
Option.