Point jcb-gdas to Argo and ADT QC updates#2111
Merged
guillaumevernieres merged 4 commits intorelease/gfs.v17from Apr 21, 2026
Merged
Point jcb-gdas to Argo and ADT QC updates#2111guillaumevernieres merged 4 commits intorelease/gfs.v17from
guillaumevernieres merged 4 commits intorelease/gfs.v17from
Conversation
JohnSteffen-NOAA
requested review from
CatherineThomas-NOAA,
guillaumevernieres and
shlyaeva
JohnSteffen-NOAA
added
draft
…es the jcb-gdas hash and includes marine ensemble mean for archiving
JohnSteffen-NOAA
force-pushed
the
feature/argo_adt_qc
branch
2 times, most recently
from
0588228 to
f8e9d89
Compare
shlyaeva
reviewed
Apr 21, 2026
Collaborator
shlyaeva
left a comment
shlyaeva
left a comment
There was a problem hiding this comment.
See a comment below, I think we need a different commit for ioda.
Comment on lines
+144
to
+148
| # Hack OOPS one line change to harden code for operations, | ||
| # remove once the change is merged into the JCSDA develop branch and we can update the submodule | ||
| sed -i 's| ASSERT(spaces_.size() >0);| // ASSERT(spaces_.size() >0);|' $dir_root/sorc/oops/src/oops/base/ObsSpaces.h | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
My eyes are closed for this part.
Collaborator
There was a problem hiding this comment.
I think we need a different commit: https://github.com/JCSDA/ioda/commits/release/2.11/, commit JCSDA/ioda@724af19.
guillaumevernieres
approved these changes
Apr 21, 2026
shlyaeva
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings in jcb-gdas configuration changes to marine QC for Argo and ADT (altimeters) observations to remove bad or biased obs from assimilation.
Update
Bugfixes added to the recentering time offset and ice thickness rescaling
Additional files generated for marine ensemble mean to be archived
IODA lat/lon check included
Companion PRs
https://github.com/NOAA-EMC/jcb-gdas/pull/233
Issues
Resolves #2100
Refs #2096
Automated CI tests to run in Global Workflow