Fix cont tag#880
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
=======================================
Coverage 84.36% 84.36%
=======================================
Files 71 71
Lines 5003 5003
=======================================
Hits 4221 4221
Misses 782 782
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ceblanton
left a comment
ceblanton
left a comment
There was a problem hiding this comment.
Could you link the issue that this PR addresses, and check the PR template boxes?
It's a CI-only update but is good practice!
|
|
||
| - name: Update fre-cli version in cylc-flow-tools.yaml | ||
| run: | | ||
| sed -i 's/^[[:space:]]*-[[:space:]]*noaa-gfdl::fre-cli==.*/ - noaa-gfdl::fre-cli==${{ steps.set_tag.outputs.docker_tag }}/' ./container-files/cylc-flow-tools.yaml |
There was a problem hiding this comment.
cylc-flow-tools.yaml still contains this old tag
dependencies:
- noaa-gfdl::fre-cli==2025.04
Why not commit the version change update to cylc-flow-tools.yaml?
There was a problem hiding this comment.
Going off of this - the hsm package could also be tagged to 1.4.0 for that hsm update (though the container that is built won't work due to the lack of fregrid - unrelated to hsm)
3 participants
Describe your changes
Adjusts tag setting logic for container auto-build
Issue ticket number and link (if applicable)
Fixes #879 (replace XXX with the issue number and GitHub will autolink the PR to the issue)
Checklist before requesting a review
Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the
release_procedure.mdtemplate. To quickly use this template, open a new pull request, choose your branch, and add?template=release_procedure.mdto the end of the url.