Skip to content

Putting fre catalog docstrings into plain sentences#905

Open
Ciheim wants to merge 3 commits into
NOAA-GFDL:mainfrom
Ciheim:main
Open

Putting fre catalog docstrings into plain sentences#905
Ciheim wants to merge 3 commits into
NOAA-GFDL:mainfrom
Ciheim:main

Conversation

@Ciheim
Copy link
Copy Markdown
Contributor

@Ciheim Ciheim commented Jun 3, 2026

Describe your changes

Issue ticket number and link (if applicable)

Fixes #XXX (replace XXX with the issue number and GitHub will autolink the PR to the issue)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

@Ciheim Ciheim self-assigned this Jun 3, 2026
Comment thread fre/catalog/frecatalog.py
@click.group(help=click.style(" - catalog subcommands", fg=(64,94,213)))
def catalog_cli():
''' entry point for click into fre catalog cli calls '''
"""This command group exposes the ``fre catalog`` subcommands."""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this -> catalog_cli?

Comment thread fre/catalog/frecatalog.py
'''
entry point for fre catalog subcommands
'''
"""This module defines the ``fre catalog`` CLI commands."""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the definition of a catalog and more detailed descriptions of the click options be coming soon? 😁

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.36%. Comparing base (e293d61) to head (bc4487c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #905   +/-   ##
=======================================
  Coverage   84.36%   84.36%           
=======================================
  Files          71       71           
  Lines        5003     5003           
=======================================
  Hits         4221     4221           
  Misses        782      782           
Flag Coverage Δ
unittests 84.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fre/catalog/frecatalog.py 94.44% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e293d61...bc4487c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants