chore: retire plan-a branch#160
Merged
Merged
Conversation
…ol/errno.rs [1.1]
…rd/embed.rs [1.3]
…_codec/embed.rs [1.3]
…desktop_shell — init/entry.rs [1.3]
…-gui bundle — Cargo.toml [1.3]
…plan-a lane) — Makefile [0.2.d]
…ee RETIRE_AUDIT.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RETIRE_AUDIT — feature/plan-a-rusty-user-surface vs main (2026-05-18)
Base:
origin/main@46fc3b5e7(#155/#156/#157/#158 merged) vsorigin/feature/plan-a-rusty-user-surface@25a49e9eb. merge-base85c53240f. Divergence: plan-a +74 / main +239; tree diff 378 files(54 plan-a-only A, 117 main-only D, 200 M, 7 R).
Verdict: retire via
-s oursis correct for 373/378 files; 5 files BLOCK it pending owner decision.Bucket 1 — Superseded (resolve to main; the 52 tagged session commits)
[0.1]→chunk A,[0.2.b]→chunk B,[1.1]→chunk B,[1.3]→chunk C,[0.2.d]→Makefile/CI lane. main holds the ported canonical equivalent ofevery file these touched. Net effect vs main: none wanted. Discard plan-a side.
Bucket 2 — Superseded by deliberate redesign (old-API app wave, commits 20-22 + app trust artifacts)
userland/capsule_{calculator,terminal,file_manager,text_editor,settings, process_manager,about}/**(old single-file app_skeleton API) → main hasthe ported multi-module canonical versions (chunk E / PR Integrate Plan A (rusty user surface) onto main #156).
nonos-data/trust/{capsules,keys}/{about,calculator,...}.*(28 files) —signed artifacts for the discarded old-API binaries; main's app model
is feature-gated unsigned dev-spawn (about-style) → these signings unused.
userland/capsule_*/Capsule.mk,*/README.md,*/Cargo.lock,src/userspace/capsule_{terminal,text_editor}/state.rs→ superseded bychunk E's no-Capsule.mk + about-style 3-file mirror design.
Discard plan-a side.
Bucket 3 — Dead code (not wanted anywhere)
userland/desktop_shell/src/main.rs— the dead shadow stub(
mk_exit(0), no Cargo.toml) flagged for deletion in the plan. Discard.Bucket 4 — main is newer (200 M + 117 D)
For every modified file main's version is the 239-commit-evolved one;
117 "D" are main-only files plan-a never had. main's side stands. Keep main.
Bucket 5 — ABSENT & potentially-wanted — OWNER DECISION (blocks blanket -s ours)
Genuine plan-a integration main lacks, from the untagged
feat()commits(
feat(desktop-shell): add wm and policy clients,feat(capsule_wallpaper): complete a3 service path) that the Step-2 port did not carry (chunk B =compositor + typed-errno only):
userland/capsule_desktop_shell/src/wm_client/mod.rsOP_HEALTHCHECKIPCcompositor_client)userland/capsule_desktop_shell/src/wallpaper_client/mod.rsOP_SET_POLICYIPCuserland/capsule_desktop_shell/src/market_client/mod.rsOP_HEALTHCHECKIPCuserland/capsule_wallpaper/src/decode_client/{header,seq}.rsdecodetyped-errno parse)Each is small (24–56 LOC) but sits on plan-a's pre-239-commit
wallpaper/desktop_shell base; porting onto main's evolved crates needs an
API-compat pass, not a blind cherry-pick.
Owner decision required: for the 5 files —
(A) Port-forward: re-implement the wm/wallpaper/market/decode client
integration against main's current
capsule_desktop_shell/capsule_wallpaper(small, but real work + API reconciliation), then retireplan-a; or
(B) Confirm-obsolete: main's desktop_shell/wallpaper intentionally
diverged (no wm/market/decode driving) → discard, retire plan-a as-is.
Recommended execution
(own PR, build-verified 3-triple), land it, then retire plan-a.
git merge -s ours origin/feature/plan-a-rusty-user-surfaceonchore/retire-plan-a(tree ≡ main, zero regression — assertgit diff origin/main HEADempty), PR, then delete the branch.-s oursis safe only after Bucket 5 is resolved by (A) or (B).