Skip to content

Replace Black and Flake8 with Ruff#103

Merged
ambarb merged 5 commits into
NSLS-II-CSX:masterfrom
nisarnk:nisar_replace-black-flake8-with-ruff
Jul 10, 2025
Merged

Replace Black and Flake8 with Ruff#103
ambarb merged 5 commits into
NSLS-II-CSX:masterfrom
nisarnk:nisar_replace-black-flake8-with-ruff

Conversation

@nisarnk

@nisarnk nisarnk commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

This PR replaces Black and Flake8 with Ruff for formatting and linting, addressing #102 and #93 .

  • Removed Black and Flake8

  • Added Ruff to requirements.txt

  • Applied Ruff auto-fixes to format code

Configuration remains implicit; no changes to pyproject.toml were made.

@maffettone

Copy link
Copy Markdown
Contributor

While we're here, let's get this green :)

This function looks like it assumes some generic im, ax, and fig in the namespace.

Can we modify that in this PR to consume those as required keyword arguments, so they are clearly available in the lower closure?

@nisarnk

nisarnk commented Jul 4, 2025

Copy link
Copy Markdown
Contributor Author

While we're here, let's get this green :)

This function looks like it assumes some generic im, ax, and fig in the namespace.

Can we modify that in this PR to consume those as required keyword arguments, so they are clearly available in the lower closure?

This is assigned to @ambarb in issue #97

@ambarb

ambarb commented Jul 10, 2025

Copy link
Copy Markdown
Member

@maffettone we addressed those issues. I don't want to close the #97 because we need to reorganize now to have generic image data helpers, but the linting issues have all been addressed. I am good to merge this

@ambarb ambarb requested review from ambarb and maffettone July 10, 2025 15:43
@ambarb ambarb merged commit b73e30c into NSLS-II-CSX:master Jul 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants