Changed version of adtimepix3#210
Open
Juan Marulanda (jmaruland) wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR pins the ADTimePix3 module used by the Timepix3 IOC deployment to an earlier Git commit to maintain compatibility with the CHX Timepix3 runtime.
Changes:
- Updated the ADTimePix3 module variable key and pinned git
versionto15009fe. - Switched the Timepix3 IOC deployment to require
adtimepix3_15009feinstead ofadtimepix3_2faf970.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| roles/install_module/vars/adtimepix3_15009fe.yml | Pins ADTimePix3’s git version and aligns the YAML variable key with the pinned module identifier. |
| roles/deploy_ioc/vars/adtimepix3.yml | Updates the required module identifier so the deploy role installs/uses the pinned ADTimePix3 version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jakub Wlodek (jwlodek)
previously approved these changes
Apr 9, 2026
Collaborator
|
Actually, before merging, we need to fix the build failures on the test deployment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the yml files that pick the latest version of adtimepix3 to use an earlier version in order to make it compatible with the current version that is being run with the timepix3 at CHX.