Xpress3 mk2#224
Open
seher karakuzu (skarakuzu) wants to merge 9 commits into
Open
Conversation
Contributor
Author
|
Hi Jakub Wlodek (@jwlodek) and Roman Chernikov (@yxrmz) , I would be happy if you take a look at the PR . I tested on a VM and had some success in building this IOC there. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ports the xspress3 IOC deployment configuration to the newer b1e03f7 module version and adjusts startup paths/settings needed by that IOC layout.
Changes:
- Updates xspress3 install/deploy vars to use
xspress3_b1e03f7. - Points the IOC template root at the built xspress3 IOC directory and adds DB include paths.
- Adjusts xspress3 generated startup files and example calibration path.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
roles/install_module/vars/xspress3_b1e03f7.yml |
Defines the xspress3 module version/config for install_module. |
roles/device_roles/xspress3/templates/postInit.cmd.j2 |
Restores cwd to iocBoot before including channel setup commands. |
roles/device_roles/xspress3/tasks/main.yml |
Uses host_config soft IOC ownership fields consistently. |
roles/device_roles/xspress3/example.yml |
Updates example calibration directory. |
roles/deploy_ioc/vars/xspress3.yml |
Switches required module, sets IOC template root, and adds EPICS DB include path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I changed the main branch commit number after this merged PR epics-modules/xspress3#85 |
Jakub Wlodek (jwlodek)
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to port the xspress3 role for mk2