Skip to content

MDrive#252

Merged
Dmitri Gavrilov (dmgav) merged 4 commits into
NSLS2:mainfrom
hxu-bnl:eps
Jun 15, 2026
Merged

MDrive#252
Dmitri Gavrilov (dmgav) merged 4 commits into
NSLS2:mainfrom
hxu-bnl:eps

Conversation

@hxu-bnl

@hxu-bnl hxu-bnl commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
  • Modify IMS to latest motor support
  • Add IMS_extra db support
  • Modify example and add CntlDev to support more flexibility
  • Modify asyn macros

Copilot AI review requested due to automatic review settings June 15, 2026 15:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the MDrive IOC deployment to use a newer IMS motor support module revision and expands the generated EPICS database substitutions to optionally support additional IMS “extra” records and more flexible asyn record naming.

Changes:

  • Switch mdrive module dependency from ims_2aeddf7 to ims_58d492d (new motorIms revision).
  • Add IMS_extra.db substitution generation to the mdrive motor substitutions template.
  • Introduce optional CntlDev device field to customize asyn record PV naming independently of Dev, and update the example config accordingly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
roles/install_module/vars/mdrive_8bc9a09.yml Updates mdrive’s module dependency to the newer IMS module var.
roles/install_module/vars/ims_58d492d.yml Defines the new IMS module revision (name/version/url).
roles/device_roles/mdrive/templates/motor.substitutions.j2 Adds loading/substitutions for $(IMS)/db/IMS_extra.db per device.
roles/device_roles/mdrive/templates/asynRecord.substitutions.j2 Uses optional CntlDev to control asyn record naming with a fallback to Dev.
roles/device_roles/mdrive/schema.yml Adds optional CntlDev field to the device schema.
roles/device_roles/mdrive/examples/mdrive-g1/config.yml Updates the example PREFIX and demonstrates CntlDev usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hxu-bnl

hxu-bnl commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Dmitri Gavrilov (@dmgav) Can you review and approve this PR? Thanks.

@dmgav Dmitri Gavrilov (dmgav) merged commit dd031bc into NSLS2:main Jun 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants