MDrive#252
Merged
Merged
Conversation
hxu-bnl
commented
Jun 15, 2026
Contributor
- Modify IMS to latest motor support
- Add IMS_extra db support
- Modify example and add CntlDev to support more flexibility
- Modify asyn macros
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MDrive IOC deployment to use a newer IMS motor support module revision and expands the generated EPICS database substitutions to optionally support additional IMS “extra” records and more flexible asyn record naming.
Changes:
- Switch
mdrivemodule dependency fromims_2aeddf7toims_58d492d(new motorIms revision). - Add
IMS_extra.dbsubstitution generation to the mdrive motor substitutions template. - Introduce optional
CntlDevdevice field to customize asyn record PV naming independently ofDev, and update the example config accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| roles/install_module/vars/mdrive_8bc9a09.yml | Updates mdrive’s module dependency to the newer IMS module var. |
| roles/install_module/vars/ims_58d492d.yml | Defines the new IMS module revision (name/version/url). |
| roles/device_roles/mdrive/templates/motor.substitutions.j2 | Adds loading/substitutions for $(IMS)/db/IMS_extra.db per device. |
| roles/device_roles/mdrive/templates/asynRecord.substitutions.j2 | Uses optional CntlDev to control asyn record naming with a fallback to Dev. |
| roles/device_roles/mdrive/schema.yml | Adds optional CntlDev field to the device schema. |
| roles/device_roles/mdrive/examples/mdrive-g1/config.yml | Updates the example PREFIX and demonstrates CntlDev usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Dmitri Gavrilov (@dmgav) Can you review and approve this PR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.