updated packages and GHA#253
Merged
Padraic Shafer (padraic-shafer) merged 9 commits intoMay 12, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Padraic Shafer (padraic-shafer)
left a comment
Collaborator
There was a problem hiding this comment.
All changes look good, though if we can continue to use any, let's use that instead of asyncio.
Co-authored-by: Copilot <copilot@github.com>
Contributor
Author
Co-authored-by: Copilot <copilot@github.com>
Padraic Shafer (padraic-shafer)
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request includes a series of dependency updates, workflow improvements, and resource management fixes across the codebase. The most significant changes are grouped below by theme.
Dependency and Development Environment Updates:
requirements-dev.txtto address security, compatibility, and feature improvements. Notable updates includeaiohttp,anyio,attrs,black,certifi,locust,pytest, and many others. Removedpytest-asyncioand added new dependencies such aspython-discoveryandvcs-versioning. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]pyproject.tomlto useanyio_modeinstead ofasyncio_modefor pytest configuration, reflecting the shift away frompytest-asyncio.pytest-asynciofromrequirements-dev.in, aligning with the above configuration change.CI/CD Workflow Improvements:
.github/workflows/docker-publish.ymlto their latest versions for improved security and reliability. Also standardized YAML formatting for consistency. [1] [2] [3]Resource Management and Database Connection Handling:
scripts/create_new_beamline.py,scripts/update_beamline.py) and the FastAPI app lifespan (src/nsls2api/infrastructure/app_setup.py) to return and explicitly close the MongoDB client, ensuring proper cleanup of resources. [1] [2] [3] [4] [5] [6] [7]Model and Schema Adjustments:
ApiUsermodel insrc/nsls2api/models/apikeys.pyto usejson_schema_extrafor theuser_api_keysfield, improving schema clarity. https://beanie-odm.dev/tutorial/relations/#back-linksProposalDisplaymodel insrc/nsls2api/models/proposals.pyto use the modernmodel_configapproach withConfigDictfor extra field handling, replacing the deprecatedConfigclass. [1] [2]Minor Script and Typing Fixes:
scripts/update_beamline.py.These changes collectively improve dependency management, resource handling, and codebase maintainability.
Commands to Upgrade Dependencies:
Test Cases Summary:
JIRA: https://jira.nsls2.bnl.gov/browse/DT1-1431