New /v1/person/proposals endpoint#256
Open
Aditi Chikkali (AditiChikkali) wants to merge 4 commits into
Open
Conversation
Collaborator
|
I would help to zoom out from the mechanical summary of file changes above and get some context about motivation. There are currently two related endpoints:
To get proposal details for proposals that a user is listed on, one could fetch the IDs from (2) and pass those to (1) to obtain the details. The proposed new endpoint in this PR makes it possible to achieve this in a single request. However, it lacks pagination. This could create a problem if the set of proposals is large. Some options to consider:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new proposals endpoint that returns proposals scoped to requesting username and current cycle.
Changes by File
1. proposal_model.py
2. proposal_service.py
3. user_api.py