ENH: if redis does not connect, suggest using ssl flag#250
Open
Thomas A Caswell (tacaswell) wants to merge 2 commits into
Open
ENH: if redis does not connect, suggest using ssl flag#250Thomas A Caswell (tacaswell) wants to merge 2 commits into
Thomas A Caswell (tacaswell) wants to merge 2 commits into
Conversation
Thomas A Caswell (tacaswell)
force-pushed
the
enh/better_error
branch
from
7cd47a0 to
75f59cd
Compare
Thomas A Caswell (tacaswell)
requested review from
RobertSchaffer1 and
Max Rakitin (mrakitin)
| redis_client = _get_client(beamline, redis_ssl, prefix) | ||
|
|
||
| try: | ||
| redis_client.ping() |
Contributor
There was a problem hiding this comment.
If we use the secure server specified via the REDIS_HOST env var without the -s option, it hangs on this step indefinitely. We may need some sort of timeout.
Max Rakitin (mrakitin)
requested changes
Jun 16, 2026
Max Rakitin (mrakitin)
left a comment
Max Rakitin (mrakitin)
left a comment
Contributor
There was a problem hiding this comment.
Need to test it with an active proposal and multiple combinations of parameters. See the problem identified below.
Contributor
|
We also need to resolve the conflicts here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.