feat: 英語名カラム追加と国際団体向け貸出PDF英語表示対応#2004
Open
hikahana wants to merge 5 commits intofeat/inaba/1992-add-eng-rental-listfrom
Open
feat: 英語名カラム追加と国際団体向け貸出PDF英語表示対応#2004hikahana wants to merge 5 commits intofeat/inaba/1992-add-eng-rental-listfrom
hikahana wants to merge 5 commits intofeat/inaba/1992-add-eng-rental-listfrom
Conversation
…es, rental items, and stocker places
…nd stocker places
Collaborator
|
@codex 日本語でレビューしてください． |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39854e5f8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
api/db/schema.rb
Outdated
Comment on lines
+164
to
+165
| t.index ["fes_year_id", "group_category_id"], name: "index_groups_on_fes_year_and_category_for_order_status" | ||
| t.index ["fes_year_id", "group_category_id"], name: "index_groups_on_fes_year_id_and_group_category_id" |
There was a problem hiding this comment.
name_en 追加とは無関係に groups へ同一カラム構成のインデックスが複数追加されており（例: [:fes_year_id, :group_category_id] が2本）、db:schema:load した環境だけで不要な重複インデックスが作成されます。これにより書き込み性能の低下と、db:migrate ベース環境との差分（スキーマドリフト）が発生するため、このコミットで混入した重複定義は除外するべきです。
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #0
概要
rental_items/stocker_places/group_categoriesにname_enを追加し、英語名を保持できるようにしました。name_en優先で表示するようにしました。実装詳細
api/db/migrate/20260214000000_add_name_en_to_master_tables.rbapi/db/schema.rbgroup_category.rb,rental_item.rb,stocker_place.rbにname_enを追加group_categories_controller.rb,rental_items_controller.rb,stocker_places_controller.rbでname_enを受け付けapi/app/controllers/print_pdf_controller.rbapi/app/views/print_pdf/output_all_groups_rental_items.pdf.erbadmin_view/nuxt-project/pages/print/index.vueに英語版ダウンロード導線を追加画面スクリーンショット等
会場割り当ては未実装なので見れない。
動作確認手順、管理画面
参加団体を作る。
物品申請をする
物品割り当てを設定する
pdf出力する
物品貸し出し表まとめ (2).pdf
テスト項目
備考
locale=en指定時は国際団体（is_international=true）で絞り込んで出力する実装です。