This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Conversation
JosephusPaye
requested review from
BrendanAnnable and
TrentHouliston
and removed request for
BrendanAnnable
TrentHouliston
approved these changes
Feb 18, 2020
Member
TrentHouliston
left a comment
TrentHouliston
left a comment
There was a problem hiding this comment.
I can't speak to if there is a better way to do this but the code seems sane and it works.
If you want to know if there is a better way to code parts you'll have to wait for @BrendanAnnable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the break up of #234 (Script Tuner), this PR adds a file tree component for browsing and selecting a file from a list of files.
Storybook: https://nusight-pr-283.herokuapp.com/storybook/?path=/story/components-file-tree--interactive