This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Make the Vision view display the visual mesh using rays#284
Merged
TrentHouliston merged 2 commits intomasterfrom Jul 5, 2019
Merged
Make the Vision view display the visual mesh using rays#284TrentHouliston merged 2 commits intomasterfrom
TrentHouliston merged 2 commits intomasterfrom
Conversation
Member
BrendanAnnable
left a comment
BrendanAnnable
left a comment
There was a problem hiding this comment.
I don't think I can review this — there are no storybooks (and no simulator?) and thus I have no idea if this is correct.
Someone who knows how to use/test this should review it 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the vision view to display using rays instead of pixel coordinates so it is able to track as the camera rotates. Pulled from #267 which will become the update for the visual mesh view to do the same