fix(docs): cherry-pick v2.6.0 Sphinx and version switcher fixes#665
Conversation
Resolve broken xrefs and lexers, add version switcher manifest hook, update versions1.json for 2.6.0-2.3.0, and apply DORI style guide fixes. Signed-off-by: Kurt Heiss <kheiss@nvidia.com> (cherry picked from commit f66cdec)
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughWalkthroughThis PR updates the NVIDIA RAG Blueprint documentation with a build-system enhancement and comprehensive content improvements. The Sphinx configuration now manages the version manifest at build time via hooks, the version list marks 2.6.0 as preferred, and feature documentation for agentic RAG, VLM, performance benchmarking, and release notes receives clarification, restructuring, and link updates to external resources. ChangesDocumentation Build System and Content Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/agentic-rag.md`:
- Around line 66-67: Replace fragile plain-fragment links that target the
existing MyST label "(enable-per-request)=" with Sphinx-style cross-references:
find occurrences of "(`#enable-per-request`)" (and any other "`#enable-per-request`"
fragments) and change them to use the MyST/Sphinx ref role syntax
{ref}`enable-per-request` so references resolve reliably across builders; update
all matching links in this document (e.g., near the earlier link around line
~32) to the new {ref}`enable-per-request` form.
In `@docs/conf.py`:
- Around line 57-62: Add missing type hints to the Sphinx extension functions:
annotate setup as def setup(app: Any) -> None and the callbacks as def
_on_builder_inited(_app: Any) -> None and def _on_build_finished(_app: Any, exc:
Optional[Exception]) -> None, and import Any and Optional from typing (or use
more specific Sphinx types if available, e.g., Sphinx from sphinx.application)
so every function signature has explicit type annotations.
In `@docs/performance-benchmarking.md`:
- Around line 163-170: The fenced JSONL example block is missing blank lines
before and after the triple-backtick fence which triggers MD031; fix the
`.jsonl` list item by ensuring there is a blank line immediately before the
opening ```json fence and a blank line immediately after the closing ``` fence
so the code block is separated from surrounding list text (adjust the fenced
JSONL example shown under the `.jsonl` bullet accordingly).
- Around line 323-332: The three fenced examples showing output layouts (the
blocks containing "run_<ts>/{report.md, results.csv, results.json, profiling/,
aiperf_rag_on/}", "run_<ts>/{profile_report.md, profile_results.json,
profiling/}", and the nested tree starting with "run_<ts>/") need a blank line
before and after each fence and must declare a language; change each fence from
``` to ```text and ensure there is an empty line separating the surrounding
paragraph and the code fence so the blocks become properly fenced (e.g., add a
blank line, replace ``` with ```text, paste the snippet, then add a blank line
after the closing fence).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 5d340e15-94f1-422e-b01d-9c4e4513a88e
📒 Files selected for processing (7)
docs/agentic-rag.mddocs/conf.pydocs/index.mddocs/performance-benchmarking.mddocs/release-notes.mddocs/versions1.jsondocs/vlm.md
Summary
Cherry-picks the docs fix from PR #664 onto
main.This updates the Sphinx docs build configuration, fixes documentation cross-reference and style issues, and updates the version switcher manifest for the v2.6.0 documentation line.
Notes
f66cdec10d5e5c2d4a77d4dde4a4b4dea37797fa875ab0a039da8869567fd82c5fadea5bfd268905docs/versions1.jsonby keepingmain's2.5.1entry and adding the newnamefields expected by the version switcher.Validation
uv run --group docs sphinx-build docs docs/_build/htmlSummary by CodeRabbit
Documentation
Chores