-
Notifications
You must be signed in to change notification settings - Fork 10
feat: rewrite evaluation improvements #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
memadi-nv
wants to merge
17
commits into
main
Choose a base branch
from
memadi/feature/update-rewrite-evaluation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b23de7c
add a plan for updating anonymizer rewrite evaluation
memadi-nv 3308479
nit
memadi-nv df3f4f2
address gliner feedback
memadi-nv 24b4185
address greptile feedback-part 2
memadi-nv 0a6f0bf
nit
memadi-nv d347463
implement the plan
memadi-nv c158670
merge main
memadi-nv 59a7c93
update evaluation-rewrite
memadi-nv 763c3a6
nit
memadi-nv fb37234
make format
memadi-nv 28cb50f
update notebooks according to the change
memadi-nv 8a1a013
remove plan
memadi-nv 52e7cbb
make judge_evaluation a user facing value
memadi-nv 7853fbd
nit
memadi-nv e078d39
fix some bugs-add some tests
memadi-nv 63d8450
update docs according to the changes
memadi-nv eb5367e
merge main
memadi-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
judge_evaluationis explicitly rendered in display_record(), I think it belongs in the same public-facing tier asutility_score,leakage_mass, anddetection_valid— all without the underscore prefix- hence removed the internal use, aka_