fix(docker): replace deprecated pynvml with nvidia-ml-py#1725
Merged
akoumpa merged 1 commit intoNVIDIA-NeMo:mainfrom Apr 8, 2026
Merged
fix(docker): replace deprecated pynvml with nvidia-ml-py#1725akoumpa merged 1 commit intoNVIDIA-NeMo:mainfrom
akoumpa merged 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: ooooo <3164076421@qq.com>
There was a problem hiding this comment.
Pull request overview
Updates the Docker build’s DeepEP patch to avoid installing the deprecated pynvml PyPI package (which triggers a PyTorch FutureWarning) by switching DeepEP’s dependency to the official nvidia-ml-py NVML bindings.
Changes:
- Update
docker/common/deepep.patchto replacepynvmlwithnvidia-ml-py>=12.0.0in DeepEP’sinstall_requires.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
/claude review |
Contributor
|
Hi @ooooo-create thanks for making this! Hi @thomasdhc can you review when you get the chance? Thanks 🙇 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
/ok to test af7f0a0 |
thomasdhc
approved these changes
Apr 8, 2026
akoumpa
pushed a commit
that referenced
this pull request
Apr 10, 2026
Signed-off-by: ooooo <3164076421@qq.com>
edjson
pushed a commit
to edjson/Automodel
that referenced
this pull request
Apr 17, 2026
…#1725) Signed-off-by: ooooo <3164076421@qq.com>
edjson
pushed a commit
to edjson/Automodel
that referenced
this pull request
Apr 18, 2026
…#1725) Signed-off-by: ooooo <3164076421@qq.com> Signed-off-by: Edison <edisonggacc@gmail.com>
linnanwang
pushed a commit
that referenced
this pull request
Apr 24, 2026
Signed-off-by: ooooo <3164076421@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes the deprecated
pynvmlpackage warning in the Docker container reported in #1722.pynvmlis currently pulled in bydeep_ep, so this updatesdocker/common/deepep.patchto replace it withnvidia-ml-py>=12.0.0ininstall_requires. The lower bound matches the compatibility floor already implied by the deprecatedpynvmlpackage itself, while switching to the official NVIDIA-maintained NVML bindings.Fixes #1722
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
hybrid-epbranch fix(hybrid-ep): replace deprecated pynvml dependency with nvidia-ml-py deepseek-ai/DeepEP#601