ci: upgrade GitHub Actions for Node.js 24 compatibility#143
ci: upgrade GitHub Actions for Node.js 24 compatibility#143
Conversation
Upgrades actions to versions compatible with the Node.js 24 runtime: - actions/checkout: → v6 - actions/upload-artifact: → v6 - actions/download-artifact: → v7 - actions/github-script: → v8 - actions/setup-python: → v6 Mirrors: NVIDIA/Megatron-LM@1d5e68b Signed-off-by: oliver könig <okoenig@nvidia.com>
Greptile SummaryThis PR performs a mechanical, repo-wide upgrade of five GitHub Actions to versions that run on the Node.js 24 runtime (
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant PR as Pull Request Push
participant PF as pre-flight
participant BC as _build_container<br/>(checkout@v6)
participant UT as cicd-unit-tests<br/>(checkout@v6)
participant UA as upload-artifact@v6
participant NT as cicd-nightly-tests<br/>(checkout@v6)
participant DA as download-artifact@v7
participant PT as publish-test-results
participant NC as Nemo_CICD_Test<br/>(checkout@v6, github-script@v8)
participant CV as Coverage<br/>(checkout@v6)
PR->>PF: trigger
PF->>BC: dispatch (self-hosted-nemo runner)
BC->>UT: image ready
UT->>UA: upload test results
BC->>NT: image ready (schedule only)
NT->>UA: upload test results
UA->>DA: artifacts stored
DA->>PT: download & publish
UT->>NC: status
NC->>CV: trigger coverage aggregation
CV->>DA: download coverage artifacts
CV->>UA: upload aggregated coverage
Reviews (1): Last reviewed commit: "ci: upgrade GitHub Actions for Node.js 2..." | Re-trigger Greptile |
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@v6 |
There was a problem hiding this comment.
Self-hosted runner version prerequisite
actions/upload-artifact@v6 (and the other Node.js 24-based actions) require a minimum Actions Runner version of 2.327.1. This workflow runs on self-hosted-nemo (a self-hosted runner), so before or alongside this merge you'll want to confirm that runner has been updated. GitHub-hosted runners on ubuntu-latest pick this up automatically, but self-hosted ones don't.
The same applies to the custom GPU runners (${{ needs.pre-flight.outputs.runner_prefix }}-gpu-x2, linux-amd64-cpu16) used in cicd-main.yml. If those runners are below 2.327.1, the jobs will fail with a node24 runtime error at startup rather than a meaningful test failure.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Upgrades all GitHub Actions to versions compatible with the Node.js 24 runtime, which GitHub is rolling out as the new runner default.
Action upgrades:
actions/checkout: any version →v6actions/upload-artifact: any version →v6actions/download-artifact: any version →v7actions/github-script: any version →v8actions/setup-python: any version →v6Mirrors: NVIDIA/Megatron-LM@1d5e68b
Test plan
🤖 Generated with Claude Code