feat(cli): expose env-only infrastructure settings as CLI flags#538
Draft
binaryaaron wants to merge 3 commits into
Draft
feat(cli): expose env-only infrastructure settings as CLI flags#538binaryaaron wants to merge 3 commits into
binaryaaron wants to merge 3 commits into
Conversation
5 settings were configurable only via environment variables with no CLI flag equivalent, making them undiscoverable through --help. Expose --nim-endpoint-url, --nim-api-key, --nim-model-id, --local-files-only, and --cpu-count as CLISettings fields with AliasChoices so env vars continue to work and CLI flags take precedence. Resolved values are propagated back to os.environ in common_setup before the deferred pii_replacer imports so the existing deep readers honor CLI overrides without threading a settings handle through every callsite. Closes #155 Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Align CLISettings and env propagation with runtime readers in pii_replacer (NSS_INFERENCE_ENDPOINT/KEY), add NSS-over-NIM alias precedence and NSS_LOG_COLOR, share env_flag_is_true for GLiNER offline parsing, and restructure environment docs with CLI flag mappings. Closes #155 Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--nim-endpoint-url,--nim-api-key,--nim-model-id,--local-files-only, and--cpu-count(closes feat: add CLI flags for env-only settings (NIM, offline mode, CPU count) #155).CLISettingswith canonicalNSS_INFERENCE_*env names and legacyNIM_*alias precedence; propagate toos.environbefore pii_replacer imports.docs/user-guide/environment.mdwith master reference table, precedence section, and CLI flag mappings.Test plan
make checktests/cli/(settings, utils, run help)tests/test_env_flags.py,tests/pii_replacer/test_detect.pymake docs-buildNotes
Follow-up work (not in this PR): thread
PiiRuntimeSettingsinto pii_replacer to remove env propagation shim.