feat(nemo-agents): add NAT Fabric adapter - #885
Closed
AjayThorve wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a Platform-owned, third-party NeMo Agent Toolkit adapter for NeMo Fabric.
The adapter keeps the referenced NAT workflow YAML authoritative and adds only
the Fabric lifecycle bridge required for invoke-only Platform execution.
This draft is stacked on #865 and should be retargeted to
mainafter #865merges.
The change:
nvidia.nemo.platform.natmetadata in the wheel data directorydiscovered by NeMo Fabric after fix: discover installed adapter descriptors NVIDIA/NeMo-Fabric#108;
start_runtime, invokes it through NATSessionManager/runner.result(), and closes it duringstop;kind: natwithout synthesizing Fabric models, skills, ortelemetry, and rejects those Platform-owned fields instead of ignoring them;
component.
NAT serve, streaming, durable Platform sessions, and Platform model/tool/MCP
normalization are intentionally out of scope.
sequenceDiagram participant Platform participant Fabric participant Adapter as "NAT adapter host" participant NAT Platform->>Fabric: agent.yaml + input Fabric->>Adapter: start(runtime context, config_file) Adapter->>NAT: enter load_workflow(config_file) NAT-->>Adapter: SessionManager Fabric->>Adapter: invoke(request) Adapter->>NAT: SessionManager.session(...) Adapter->>NAT: session.run(input, RUN_OR_SERVE) Adapter->>NAT: runner.result() NAT-->>Adapter: workflow result Adapter-->>Fabric: normalized success/failure output Fabric->>Adapter: stop(runtime_id) Adapter->>NAT: exit load_workflow context NAT->>NAT: shutdown sessions, builders, componentsWhere should the reviewer start?
Start with
plugins/nemo-agents/src/nemo_agents_plugin/fabric/adapters/nat/adapter.py,then review the descriptor packaging in
plugins/nemo-agents/pyproject.tomland the NAT branch in
plugins/nemo-agents/src/nemo_agents_plugin/fabric/translator.py.Validation
ruff checkandruff format --checkon the changed Python filesNAT subprocess boundary
share/nemo-fabric/adapters/nemo-platform-nat/fabric-adapter.jsonwithout invoking the external model
The installed-discovery E2E used NeMo Fabric native runtime built from merged
NVIDIA/NeMo-Fabric#108 (
c8bc400) because the post-#108 PyPI build is notavailable yet.
Draft blocker
The dependency pins assume the first post-#108 build,
0.1.0a20260724. Regenerateuv.lockand the license artifacts after thatrelease is available on PyPI.
Related Issues