diag: rename 'Device IDs' to 'PCI Device IDs' in dcgmi diag output#286
Open
cluster2600 wants to merge 1 commit intoNVIDIA:masterfrom
Open
diag: rename 'Device IDs' to 'PCI Device IDs' in dcgmi diag output#286cluster2600 wants to merge 1 commit intoNVIDIA:masterfrom
cluster2600 wants to merge 1 commit intoNVIDIA:masterfrom
Conversation
The dcgmi diag metadata section labels the PCI device ID column as 'GPU Device IDs Detected', which is misleading on multi-GPU systems where every GPU of the same model shares an identical PCI device ID. Users reasonably expect N distinct values for N GPUs. Rename the label to 'GPU PCI Device IDs Detected' so it accurately reflects that the values are PCI hardware SKU identifiers rather than unique per-GPU identifiers. Also update the corresponding JSON string constant NVVS_GPU_DEV_IDS for consistency. Fixes: NVIDIA#282 Signed-off-by: Maxime Grenu <maxime.grenu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On multi-GPU systems where every GPU is the same model,
dcgmi diagdisplays ametadata row labelled "GPU Device IDs Detected" followed by a list of
identical values (e.g.
3182, 3182, 3182, 3182, 3182, 3182, 3182). This isconfusing because the label implies each value uniquely identifies a GPU, when in
reality the values are PCI device IDs — a hardware SKU identifier that is
shared across all GPUs of teh same model.
This change renames the label to "GPU PCI Device IDs Detected" so that the
output accurately communicates what the values represent. The corresponding JSON
string constant
NVVS_GPU_DEV_IDSis also updated for consistency.What changed
dcgmi/Diag.cpp"{} Device IDs Detected"to"{} PCI Device IDs Detected"nvvs/include/NvvsJsonStrings.hNVVS_GPU_DEV_IDSupdated from"GPU Device IDs"to"GPU PCI Device IDs"Before / After
Before:
After:
The word "PCI" makes it immediately clear that these are hardware-level
identifiers, and that identical values across GPUs is the expected behaviour for
GPUs of the same model.
Fixes #282