Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Comments

Show DB backend on home and model creation pages#323

Merged
lukeyeager merged 1 commit intoNVIDIA:masterfrom
gheinrich:show_db_backend
Sep 22, 2015
Merged

Show DB backend on home and model creation pages#323
lukeyeager merged 1 commit intoNVIDIA:masterfrom
gheinrich:show_db_backend

Conversation

@gheinrich
Copy link
Contributor

note: doesn't show a badge for generic datasets

@lukeyeager lukeyeager added the UI label Sep 21, 2015
@lukeyeager
Copy link
Member

Looks fine to me. Things are starting to get a little cluttered on the home page, but @jmancewicz should be revamping the whole thing with #240 soon anyway.

note: doesn't show a badge for generic datasets

Let's just put an LMDB badge on all of them since that's the only backend supported at the moment anyway. It would probably be a good idea to actually add a backend field to generic datasets too, since we'll be supporting more options in the future.

@gheinrich
Copy link
Contributor Author

Actually, in my understanding image dataset jobs (neither generic nor classification ones) don't have a backend field. For image classification datasets, the information is coming from the training DB task (there is an assumption that an image classification dataset uses a consistent DB backend). The thing is generic datasets don't have a training DB task. Where do you suggest I add the backend field?

@lukeyeager
Copy link
Member

For image classification datasets, the information is coming from the training DB task (there is an assumption that an image classification dataset uses a consistent DB backend).

Good point, that is a little strange.

The thing is generic datasets don't have a training DB task. Where do you suggest I add the backend field?

In the AnalyzeDbTask's.

lukeyeager added a commit that referenced this pull request Sep 22, 2015
Show DB backend on home and model creation pages
@lukeyeager lukeyeager merged commit 268ab35 into NVIDIA:master Sep 22, 2015
@gheinrich gheinrich deleted the show_db_backend branch October 4, 2015 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants