Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Comments

Remove update_ago_timer variable and update_ago function.#556

Closed
dongjoon-hyun wants to merge 1 commit intoNVIDIA:masterfrom
dongjoon-hyun:remove_update_ago_timer_and_function
Closed

Remove update_ago_timer variable and update_ago function.#556
dongjoon-hyun wants to merge 1 commit intoNVIDIA:masterfrom
dongjoon-hyun:remove_update_ago_timer_and_function

Conversation

@dongjoon-hyun
Copy link
Contributor

Start Time shows the start time of the job and doesn't seem to use these any more.
The timer calls this function every second (in comments it should be 5),
but the function update_ago just returns without doing anything.

@lukeyeager
Copy link
Member

@jmancewicz - any reason to keep these around?

@jmancewicz
Copy link
Contributor

It updates the duration for running jobs on the front page.

@lukeyeager
Copy link
Member

What about this return statement though:
https://github.com/NVIDIA/DIGITS/blob/v3.1.0/digits/templates/job_management.html#L41

@jmancewicz
Copy link
Contributor

Ah. I don't recall. I'll have to look into this today. I do recall that there was some issue with getting the time to feel right.

@dongjoon-hyun
Copy link
Contributor Author

Hi! :-)

@dongjoon-hyun
Copy link
Contributor Author

Ping! :)

@dongjoon-hyun
Copy link
Contributor Author

Hi, @lukeyeager and @jmancewicz .
It's okay to close this PR if the code is intentionally designed like that.
Just leave a message for a record. :)

`Start Time` shows the start time of the job and doesn't seem to use these any more.
The timer calls this function every second (in comments it should be 5),
but the function `update_ago` just returns without doing anything.
@dongjoon-hyun
Copy link
Contributor Author

Rebased.

@lukeyeager
Copy link
Member

I just looked into this and it looks like Joe disabled the "ago" thing with #380 which was originally added with #240.

I'm in favor of just deleting all of the "ago"-related stuff, including two files in static/js/:

lukeyeager@f3746f4

@jmancewicz does that look right to you? Do you think we need to figure out how to fix the time-sync issues or can we just abandon the feature?

@dongjoon-hyun
Copy link
Contributor Author

Oh, that sounds great to me.
I can handle all of them by updating this PR if you want.

@jmancewicz
Copy link
Contributor

That looks great. Good to have it cleaned out.

@lukeyeager
Copy link
Member

Thanks for getting back to us @jmancewicz. @dongjoon-hyun I'll let you update this PR unless you'd rather me just do it myself.

@dongjoon-hyun
Copy link
Contributor Author

Thank you, @lukeyeager . It's my pleasure. I'll update this PR soon. :)

@dongjoon-hyun
Copy link
Contributor Author

Oh, @lukeyeager .
After looking back the code and yours, I realized that you've already finished two days ago what you want in the Remove cruft for printing 'X time ago' on homepage.

If that is true, you can close my PR and merge yours. It's no problem. I respect DIGITS upstream. :)
+1 for your commit. :)

@lukeyeager
Copy link
Member

Closed in favor of #602.

@lukeyeager lukeyeager closed this Feb 25, 2016
@dongjoon-hyun dongjoon-hyun deleted the remove_update_ago_timer_and_function branch February 26, 2016 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants