Remove update_ago_timer variable and update_ago function.#556
Remove update_ago_timer variable and update_ago function.#556dongjoon-hyun wants to merge 1 commit intoNVIDIA:masterfrom dongjoon-hyun:remove_update_ago_timer_and_function
update_ago_timer variable and update_ago function.#556Conversation
|
@jmancewicz - any reason to keep these around? |
|
It updates the duration for running jobs on the front page. |
|
What about this |
|
Ah. I don't recall. I'll have to look into this today. I do recall that there was some issue with getting the time to feel right. |
|
Hi! :-) |
|
Ping! :) |
|
Hi, @lukeyeager and @jmancewicz . |
`Start Time` shows the start time of the job and doesn't seem to use these any more. The timer calls this function every second (in comments it should be 5), but the function `update_ago` just returns without doing anything.
|
Rebased. |
|
I just looked into this and it looks like Joe disabled the "ago" thing with #380 which was originally added with #240. I'm in favor of just deleting all of the "ago"-related stuff, including two files in @jmancewicz does that look right to you? Do you think we need to figure out how to fix the time-sync issues or can we just abandon the feature? |
|
Oh, that sounds great to me. |
|
That looks great. Good to have it cleaned out. |
|
Thanks for getting back to us @jmancewicz. @dongjoon-hyun I'll let you update this PR unless you'd rather me just do it myself. |
|
Thank you, @lukeyeager . It's my pleasure. I'll update this PR soon. :) |
|
Oh, @lukeyeager . If that is true, you can close my PR and merge yours. It's no problem. I respect DIGITS upstream. :) |
|
Closed in favor of #602. |
Start Timeshows the start time of the job and doesn't seem to use these any more.The timer calls this function every second (in comments it should be 5),
but the function
update_agojust returns without doing anything.